On Tue, Feb 07, 2012 at 06:02:38PM -0500, Will Woods wrote:
> This replaces Flags.cmdline (and Flags.createCmdlineDict()) with a new
> BootArgs class.
>
> BootArgs' parsing is slightly cleaner and it reads from other data
> locations (/run/initramfs/etc/cmdline for example).
>
> It's a subclass of OrderedDict, so things specified later
> on the boot commandline can override things near the start.
> ---
Cosmetic stuff that bugs me :)
1. docstrings should be """ not '''
2. multiline docstrings should end with """ on a line by itself
3. single line if's should still have the execution block on the next
line. eg.
if files:
self.read(files)
Functionally it looks good.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgpEa_l98khPu.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
