Re: [LORAX 2/2] lorax: copy kickstarts into sysroot (#743135)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-01-25 at 22:03 -0800, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@xxxxxxxxxx>
> 
> The installer no longer has access to the initrd's root. We need to
> copy any needed files over to /sysroot before switching root. This
> copies *.cfg and *.ks files.
> 
> It also adds the ability to add dracut hook scripts to the initramfs
> from /usr/share/lorax/dracut_hooks/
> 
> This re-adds commit af6d4e2c50072eb3d76242481cb6c1bc016f6f54 which was
> lost during the switch to the treebuilder branch.

Oh! Sorry about that.

This patch looks fine, so feel free to push. A couple notes below just
for the record..

> diff --git a/share/dracut_hooks/99anaconda-copy-ks.sh b/share/dracut_hooks/99anaconda-copy-ks.sh
> new file mode 100644
> index 0000000..ed52088
> --- /dev/null
> +++ b/share/dracut_hooks/99anaconda-copy-ks.sh
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +# Copy over kickstart files from the initrd to the sysroot before pivot
> +cp /*cfg /*ks /sysroot/ 2> /dev/null
> +

99anaconda-copy-ks.sh will be absorbed into the upcoming "anaconda"
dracut module, so this should get dropped when that happens.

> +    def copy_dracut_hooks(self, hooks):
> +        """ Copy the hook scripts in hooks into the installroot's /tmp/
> +        and return a list of commands to pass to dracut when creating the
> +        initramfs
> +
> +        hooks is a list of tuples with the name of the hook script and the
> +        target dracut hook directory
> +        (eg. [("99anaconda-copy-ks.sh", "/lib/dracut/hooks/pre-pivot")])

I'd rather see this stuff happen in the templates somewhere, but since
dracut still gets invoked outside the templates there's really no other
way to do it.

-w

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux