> These is v2 of [7/7] patches I sent - with Chris's comments applied > (squashed into 5; destroy() replaced with set_no_show_all() + hide(); > and making device list h-scrollable so that for long device descriptions) I applied to a temp branch and checked it out in a VM. Overall, this looks good. I had a very few comments about integration with the hub. On the device list, I was more looking for text wrapping than a scrolled window. I think a scrolled window there looks a little goofy. I should have been more specific in my original comments. Our mockups also provided for network configuration before the first hub (http://linuxgrrl.com/fedora-ux/Projects/Anaconda/Prototypes/ToPrint/, screens 01-network*). Have you given any thought to how this code can get used there as well? - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
