Re: [PATCH 4/7] Add a testing flag to allow limited use as non-root.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > @@ -1179,7 +1180,7 @@ class DeviceTree(object):
> >              elif device.format.uuid in self.__luksDevs:
> >                  log.info("skipping previously-skipped luks device %s"
> >                              % device.name)
> > -            elif self._cleanup:
> > +            elif self._cleanup or flags.testing:
> >                  # if we're only building the devicetree so that we can
> >                  # tear down all of the devices we don't need a passphrase
> >                  if device.format.status:
> > @@ -1794,8 +1795,6 @@ class DeviceTree(object):
> >              self.protectedDevNames.append(livetarget)
> >  
> >          cfg = self.__multipathConfigWriter.write(self.mpathFriendlyNames)
> > -        old_devices = {}
> > -
> >          if os.access("/etc/multipath.conf", os.W_OK):
> >              with open("/etc/multipath.conf", "w+") as mpath_cfg:
> >                  mpath_cfg.write(cfg)
> > @@ -1803,6 +1802,7 @@ class DeviceTree(object):
> >              self.topology = devicelibs.mpath.MultipathTopology(udev_get_block_devices())
> >              log.info("devices to scan: %s" %
> >                       [d['name'] for d in self.topology.devices_iter()])
> > +            old_devices = {}
> This causes traceback because if os.access test fails, old_devices is
> not instantiated but is later used.

Yeah, it looks like we got some things crossed here.  It still needs to
get created at the same place where it's being removed in this patch.  I
can fix that, if no one else has yet.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux