Re: [PATCH newui 3/5] Basic ethernet and wireless support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +        # or use set_no_show_all() and hide()?
> +        self.builder.get_object("hbox_1").destroy()
> +        self.builder.get_object("start_hotspot_button").destroy()
> +        self.builder.get_object("stop_hotspot_button").destroy()
> +        self.builder.get_object("heading_hotspot_network_name").destroy()
> +        self.builder.get_object("heading_hotspot_security_key").destroy()
> +        self.builder.get_object("label_hotspot_network_name").destroy()
> +        self.builder.get_object("label_hotspot_security_key").destroy()
> +        self.builder.get_object("devices_toolbar").destroy()
> +        self.builder.get_object("button_unlock").set_sensitive(False)
> +        self.builder.get_object("hbox54").destroy()
> +
> +        self.builder.get_object("notebook_types").set_show_tabs(False)

It's all a matter of what you think is more maintainable.  I'd prefer
either the widgets completely removed from the glade file, or at least
marked no_show_all and not visible.  However, that will make syncing up
with the upstream glade file more difficult in the future.  I'll defer
to your judgement as the person who'll have to do this.

>      def apply(self):
>          pass

In the future, your apply method will need to modify ksdata.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux