Re: grubby: linking to glib-2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/2011 01:08 PM, Cleber Rosa wrote:
Hi,

I've noticed that grubby's Makefile links to glib-2.0, but it does not
seem to be needed at all:

ping?

# git diff
diff --git a/Makefile b/Makefile
index f13f330..8b188f1 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,6 @@ CFLAGS += $(RPM_OPT_FLAGS) -std=gnu99 -Wall -Werror
-Wno-error=unused-function -
LDFLAGS :=

grubby_LIBS = -lblkid -lpopt
-grubby_LIBS += $(shell pkg-config --libs glib-2.0)

all: grubby


# make
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -DVERSION='"8.3"' -c -o grubby.o grubby.c
gcc -std=gnu99 -Wall -Werror -Wno-error=unused-function
-Wno-unused-function -ggdb -o grubby grubby.o -lblkid -lpopt


Any not-so-obvious reasons for that? Care for a formal patch?

Cheers.
CR.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux