Re: [PATCH] If no AP is selected don't write config files (#750896)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-11-02 at 15:43 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@xxxxxxxxxx>
> 
> When the user cancels the SSID dialog we should not be writing
> any config files. Previously we would write config files for all
> of the seen AP's, any of which may belong to Eve.

Ack.

> ---
>  pyanaconda/gui.py     |    2 +-
>  pyanaconda/network.py |    3 +++
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py
> index a1d8613..e6fad4b 100755
> --- a/pyanaconda/gui.py
> +++ b/pyanaconda/gui.py
> @@ -937,7 +937,7 @@ class InstallInterface(InstallInterfaceBase):
>                  dev_all_ssids = self.anaconda.network.getSSIDs()
>                  w.pop()
>                  # select wireless APs
> -                dev_ssids = selectSSIDsDialog(dev_all_ssids) or dev_all_ssids
> +                dev_ssids = selectSSIDsDialog(dev_all_ssids)
>                  self.anaconda.network.writeSSIDifcfgs(dev_ssids)
>  
>              self.anaconda.network.writeIfcfgFiles()
> diff --git a/pyanaconda/network.py b/pyanaconda/network.py
> index 581ea72..4e64684 100644
> --- a/pyanaconda/network.py
> +++ b/pyanaconda/network.py
> @@ -574,6 +574,9 @@ class Network:
>          return ifaces
>  
>      def writeSSIDifcfgs(self, devssids):
> +        if not devssids:
> +            return
> +
>          ssids = []
>          for ssidlist in devssids.values():
>              ssids.extend(ssidlist)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux