Hey Mark - thanks for sending this patch! On Tue, 2011-10-25 at 15:48 -0500, Mark Hamzy wrote: > Here is a proposed patch that updates a PowerPC's BIOS to boot from > the newly installed hard disk rather than back to the installer. Heh, HTML email breaks inline python super-hard. You might want to try attaching it as a file - preferably created with git format-patch, like: git format-patch -1 [commitid] But a link to fpaste would work in a pinch (just *thinking* about trying to do attachments with Notes makes my brain throb a little..) Can you give us a general idea of what this patch is trying to do? AFAICT it's updating nvram to make the OF 'boot-device' variable point to the device we're installing on. Is that right? > + def install(self, install_root=""): > + import platform > + > + platform.updatePowerPCBootList(self.storage) Why not just make updatePowerPCBootList() a method of IPSeriesYaboot? > +def updatePowerPCBootList(storage): [snip] > + prep_locations = [] So, it needs a list of PREP locations? I feel like that information might already available inside the IPSeriesYaboot class - like from the stage1_devices property. (Another reason to move this method there.) I'm not really an expert on how the bootloader/platform stuff works, though - can anyone help clarify here? -w _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
