On 10/10/2011 08:52 PM, Brian C. Lane wrote:
This is not logged anywhere else and so can shorten the needinfo
> communication by one round.
> ---
> pyanaconda/bootloader.py | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index 6c732a0..79cf499 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -1224,6 +1224,7 @@ class GRUB(BootLoader):
> grub_root = self.grub_device_name(self.stage2_device)
> args.update(["ro", "root=%s" % image.device.fstabSpec])
> args.update(self.boot_args)
> + log.info("bootloader.py: used boot args: %s " % args)
> if isinstance(image, TbootLinuxBootLoaderImage):
> args.update(image.args)
> snippet = ("\tkernel %(prefix)s/%(multiboot)s %(mbargs)s\n"
I'd move this one down to just before config.write(stanza) so you catch the
args.update for Tboot
Thanks I missed it. The patch is now:
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -1219,8 +1219,8 @@ class GRUB(BootLoader):
def write_config_images(self, config):
""" Write image entries into configuration file. """
for image in self.images:
+ args = Arguments()
if isinstance(image, LinuxBootLoaderImage):
- args = Arguments()
grub_root = self.grub_device_name(self.stage2_device)
args.update(["ro", "root=%s" % image.device.fstabSpec])
args.update(self.boot_args)
@@ -1252,6 +1252,7 @@ class GRUB(BootLoader):
% {"label": image.label,
"grub_root":
self.grub_device_name(image.device)})
+ log.info("bootloader.py: used boot args: %s " % args)
config.write(stanza)
I needed to move args out of the if so it always exists (even if empty).
Ales
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
