Re: [PATCH] Fix detection of RAW driverdisc partitions while in manual selection mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

no it doesn't have to be another step, but the logical meaning of partition selection is only partition selection. I believe it is better to separate the steps for better readability.

----- Original Message -----
> > @@ -548,6 +550,12 @@ int loadDriverFromMedia(int class, struct
> > loaderData_s *loaderData,
> >                  break;
> >              }
> >  
> > +            /* check if the partition contains the DD in raw
> > format */
> > +            if (verifyDriverDisk("/tmp/dpart") == LOADER_OK) {
> > +                stage = DEV_LOADRAW;
> > +                break;
> > +            }
> > +
> >              ddfile = newt_select_file(_("Select driver disk
> >              image"),
> >                                        _("Select the file which is
> >                                        your driver "
> >                                          "disk image."),
> 
> Does this really need to be a separate step, or can you just
> substitute
> the contents of DEV_LOADRAW into the if block above?  I don't see
> another way to get into the new step.
> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
> 

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux