On Tue, Sep 20, 2011 at 09:04:21AM +0200, Martin Gracik wrote: > Looks fine, but I still don't like how we pass the parameters to these > functions. Why do we need to pass GROUP separately when it is already in > the dict, that is passed there too? What if these parameters are > different? I bet that only one gets used and the other is ignored, and > that's not very elegant imho. Thanks for the review, I'll fixup the gid check before pushing. The reason for the two parameters is that one is required and all the kwargs are optional. If we just passed kwargs then it is less clear to callers what is required. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgpVQjU5nD2wk.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
