Hi, Replying in the wrong place in the thread but I already deleted the original patch. <snip>
--- a/storage/fcoe.py +++ b/storage/fcoe.py @@ -129,9 +129,16 @@ class fcoe(object): iutil.execWithRedirect("fipvlan", [ nic, "-c", "-s" ], stdout = "/dev/tty5", stderr="/dev/tty5") else: - f = open("/sys/module/libfcoe/parameters/create", "w") - f.write(nic) - f.close() + # Use fipvlan instead of fcoe's create if nic uses bnx2x driver. + # Ideally, this should be done by checking a "AUTO_VLAN" parameter, + # not bnx2x driver usage + if 'bnx2x' in os.path.realpath('/sys/class/net/%s/device/driver' %(nic)): + iutil.execWithRedirect("fipvlan", ['-c', '-s', nic], + stdout = "/dev/tty5", stderr="/dev/tty5") + else: + f = open("/sys/module/libfcoe/parameters/create", "w") + f.write(nic) + f.close()
Hmm, maybe "fipvlan -c -s nic" will also work for Intel fcoe, if not you should get in touch with fipvlan upstream and ask them to fix this. I know that for RHEL 6.x that is not really going to help, but it would be nice to eventually get a cleaner fix in Fedora (and if possible remove all sorts of driver specific knowledge from the anaconda code and let fipvlan deal with it all) Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
