On Thu, Jul 14, 2011 at 09:23:45AM -0500, David Lehman wrote: > Perhaps you could add checks for each of the utilities in your dict so > support for a given format is automatically removed when required > utilities are not present. pyanaconda.iutil.find_program_in_path can do > this for you. I don't have a clear thing to do other than give a more useful error if you provide an unsupported archive type, but that I've done; thanks for the pointer to find_program_in_path. > Some kind of error handling/reporting should be present for failure to ... OK. I think I've got them all now, via reasonably descriptive local error classes and some try/except blocks. > One last little nit is that there's an extra 'return source' at the end > of archiveSource. Oops; the result of earlier refactoring. Thanks much for the review! _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
