On Fri, Jun 24, 2011 at 04:31:43PM -0500, David Lehman wrote: > Stage1 requirements like PReP, EFI, &c are not bootloader- > specific, but platform-specific. Disklabel types are also > dependant on the platform. > > Move bootloader from Platform into Anaconda. Also move > bootDevice, bootLoaderDevice, bootFSTypes, and > defaultBootFSTypes from Platform into Storage. Remove > boot kwarg from storage.formats.get_default_filesystem_type > to eliminate the need for platform or anaconda instances > there. > --- [snip] > + description = self.device_description(device) > + device_types = self.platform._boot_stage1_device_types > + format_types = self.platform._boot_stage1_format_types > + mountpoints = self.platform._boot_stage1_mountpoints > + raid_levels = self.platform._boot_stage1_raid_levels > + raid_member_types = self.platform._boot_stage1_raid_member_types > + raid_metadata = self.platform._boot_stage1_raid_metadata > + max_end_mb = self.platform._boot_stage1_max_end_mb [snip] Shouldn't these be properties of platform? You're accessing private variables from outside the class. Or maybe combine them all into a boot_stage1 dict property thing instead of individual variables. Other than that I think these 3 patches look good. I think moving things into platform makes sense. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgp1efRVKtPow.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
