The check is already there, take a look at around line 190:
if(errno!=EEXIST) {
logMessage(ERROR, "Failed to create device node (%s %i:%i).", dnode, major, minor);
}
The error will be printed only for nonexisting devices. It will return error return code, which causes the new device counter will not be incremented. That is not a problem though as we are not checking the counter in this case.
--
Martin SivÃk
msivak@xxxxxxxxxx
Red Hat Czech
Anaconda team / Brno, CZ
----- Original Message -----
> > diff --git a/loader2/loader.c b/loader2/loader.c
> > index 9729072..78d7ff4 100644
> > --- a/loader2/loader.c
> > +++ b/loader2/loader.c
> > @@ -1741,6 +1741,9 @@ int main(int argc, char ** argv) {
> > mlLoadModuleSet("mlx4_en", modLoaded, modDeps, modInfo);
> > }
> >
> > + /* If we got new devices from the DDs, they need their /dev/node
> > to be created here */
> > + createPartitionNodes();
> > +
> > /* JKFIXME: loaderData->ksFile is set to the arg from the
> > command line,
> > * and then getKickstartFile() changes it and sets
> > FL_KICKSTART.
> > * kind of weird. */
>
> It looks like createPartitionNodes will try to create the device nodes
> that have already been created, which will lead to error messages
> being
> logged. Even though that's not a problem, I can already see the bugs
> getting filed about it. You may want to add a check to createDevNode
> to
> quit if the node already exists.
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
