Re: [master 08/15] dispatch: Fix rules for running the bootloader and instbootloader steps.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




--- a/pyanaconda/iw/upgrade_bootloader_gui.py
+++ b/pyanaconda/iw/upgrade_bootloader_gui.py
@@ -43,12 +43,11 @@ class UpgradeBootloaderWindow (InstallWindow):
              self.dispatch.skipStep("bootloader")
              self.dispatch.skipStep("instbootloader")
          elif self.newbl_radio.get_active():
-            self.dispatch.skipStep("bootloader", skip = 0)
-            self.dispatch.skipStep("instbootloader", skip = 0)
+            self.dispatch.request_step("bootloader")

Shouldn't there also be:
     self.dispatch.request_step("instbootloader")


No, I was looking at how those steps interact and it is the bootloader step that decides to request or skip instbootloader (which sounds logical to me). This is the exact situation that would cause a DispatchError (trying to skip step that was requested).

Unfortunately it means the mapping is not 1:1 from the old functions but that's the cost of making the API stricter and providing more guarantees.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux