Re: [PATCH] Use process-specific name for dm devices.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 04, 2011 at 10:42:14AM -0400, Peter Jones wrote:
> If you're doing e.g. an i386 build an an x86_64 build at the same time,
> you wind up deadlocking the dmsetup processes in sys_semtimedop()
> because they have the same name between the two codepaths. This is
> probbaly a dmsetup bug, but even if it weren't, you'd still have two
> composes trying to use the same dm devices, and that's bad.  Instead,
> stick the pid in the names.
> ---
>  src/pylorax/__init__.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/pylorax/__init__.py b/src/pylorax/__init__.py
> index 6e0f3c4..5eded80 100644
> --- a/src/pylorax/__init__.py
> +++ b/src/pylorax/__init__.py
> @@ -689,7 +689,8 @@ class Lorax(BaseLoraxClass):
>              return None
>  
>          # create dm device
> -        dmdev = create_dm_dev("efiboot", disksize / 512, loopdev)
> +        tablename = "efiboot%s" % (os.getpid(),)
> +        dmdev = create_dm_dev(tablename, disksize / 512, loopdev)
>  
>          if not dmdev:
>              remove_loop_dev(loopdev)

Makes sense to me.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpkUe6alhmPY.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux