Re: [PATCH] If there are no RAID arrays, do not write an mdadm.conf (#696907).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I'm not sure this is a good idea. I'm getting a bit rusty wrt
RAID things now, but IIRC, we need to write out an mdadm.conf with
"AUTO +imsm +1.x -all"

In there, even on a system without any arrays, to ensure that any
Intel BIOS RAID arrays which are created on a system (from the BIOS)
post install, will get properly activated.

All in all my 2 cents are that this fix is a bit risky this late
in the cycle. Esp. when there is a much easier low risk fix 696907
available in the form of making initscripts check that /sbin/mdadm
exists before trying to execute it.

TBH I don't see how this is an anaconda bug at all.

Regards,

Hans



On 04/15/2011 05:12 PM, Chris Lumens wrote:
---
  pyanaconda/storage/__init__.py |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py
index 825da11..6d0933d 100644
--- a/pyanaconda/storage/__init__.py
+++ b/pyanaconda/storage/__init__.py
@@ -2313,6 +2313,8 @@ class FSSet(object):
          # assemble the whole stack in one go unless listed in the proper order
          # in mdadm.conf
          arrays.sort(key=lambda d: d.path)
+        if not arrays:
+            return ""

          conf = "# mdadm.conf written out by anaconda\n"
          conf += "MAILADDR root\n"

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux