Re: [rhel5-branch] Fix shlex traceback if pxeboot cmdline ends in a quote (#500198)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 24, 2011 at 05:15:44PM -0400, Will Woods wrote:
> There's a pxelinux bug where it fails to add the beginning quote
> when it tries to add BOOT_IMAGE= to the commandline and the label
> has spaces (you get e.g.: 'linux BOOT_IMAGE=vmlinuz with label"')
> 
> Previously we tried to fix this up by adding a quote after
> BOOT_IMAGE= whenever the cmdline ends in a quote. This causes us
> to have unbalanced quotes if the cmdline is something like:
>     linux BOOT_IMAGE=vmlinuz ethtool="speed 100 duplex"
> 
> With this change, we now split the commandline at BOOT_IMAGE= and
> check to see if the right side has unbalanced quotes. If so, we add
> a quote after BOOT_IMAGE=.

This does work, as long as there are no other unbalanced quotes. But
that's a user problem, so Ack.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpyA9EHGNIgs.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux