Re: [PATCH 7/7] Convert livecd.py to use the storage module where appropriate.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-01-07 at 16:29 -0500, Chris Lumens wrote:
> > Weird. I could swear I tested this. Also, wow -- I mistakenly assumed
> > all of anaconda's classes were new-style.
> 
> AnacondaBackend is old, old stuff.
> 
> > > You could also convert backend.py:doBackendSetup to just pass instead of
> > > raise an error, and then get rid of this method entirely.  I'd be fine
> > > with that.
> > 
> > There are at least eight of these that raise NotImplementedError. I like
> > the idea of making them pass instead.
> 
> The way I see it, if a method is strictly required to be implemented by
> all backends, the abstract one should raise NIE.  If it's not strictly
> required, it should just pass.

Agreed, but that's beyond the scope of this patch set. I'll handle it
separately. New version of patch 7 sent to the list which does not try
to use a property for self.osimg but instead accesses the data directly
from self.anaconda.storage.

Dave

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux