On 01/06/2011 05:24 PM, David Lehman wrote:
Please do use udev_device_is_dm_mpath instead of adding another function to do the same thing. I forgot that function had made it to rhel6-branch. Dave
I said yesterday this is good, but now I've found one more thing we need to address first. I can not use udev_device_is_dm_mpath to test for a partition of an mpath device, the function uses udev_device_dm_subsystem_match() that looks at the first field in DM_UUID which is like "mpath-2003013842bcb000c" for multipath devices but "part1-mpath-2003013842bcb000c" for multipath partitions.
I could workaround this on rhel6 branch where there still is the disgraceful udev_device_is_multipath_partition(), but then I'd hit the problem on master where the function was removed.
I am thinking about solving this by adding a parameter to ude_device_dm_subsystem_match() that will make it skip the first DM_UUID field if it was 'part\d+'.
Ales _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
