On Mon, 2010-11-15 at 11:36 -0500, Chris Lumens wrote: > > @@ -2133,13 +2152,8 @@ class LVMVolumeGroupDevice(DMDevice): > > # TODO: just ask lvm if isModified returns False > > > > # total the sizes of any LVs > > - used = 0 > > - size = self.size > > - log.debug("%s size is %dMB" % (self.name, size)) > > - for lv in self.lvs: > > - log.debug("lv %s uses %dMB" % (lv.name, lv.vgSpaceUsed)) > > - used += self.align(lv.vgSpaceUsed, roundup=True) > > - > > + log.debug("%s size is %dMB" % (self.name, self.size)) > > + used = sum(lv.size for lv in self.lvs) + self.snapshotSpace > > Don't you want brackets around the list comprehension here? If I leave them out it just runs as a generator IIRC. I verified by running sum(x for x in range(5)) in python shell. Dave > > - Chris > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list