Re: [PATCH 3/7] Remove mkdirChain() from isys, use g_mkdir_with_parents()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack,

just one comment:

On 11/02/2010 09:44 PM, David Cantrell wrote:
+    if (g_mkdir_with_parents(file, 0755) == -1)
+        logMessage(ERROR, "mkdir error on %s: %m", file);
+
+    if (g_mkdir_with_parents(DD_MODULES, 0755) == -1)
+        logMessage(ERROR, "mkdir error on %s: %m", DD_MODULES);

Maybe we should have a function to call instead of g_mkdir_with_parents that would both call g_mkdir_with_parents() and then do the logging. Would save us some lines and ifs.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux