> These patches reimplement sorting and pruning of device actions using > topological sort and add unit tests for device actions as well as tsort. > Also included is a base class for storage tests that do not require root > access. > > The main patches are 7,8,9,11,15. The rest is groundwork, cleanup, and > fixes for bugs I turned up in testing. > > pyanaconda/storage/deviceaction.py | 228 ++++++++ > pyanaconda/storage/devices.py | 26 > pyanaconda/storage/devicetree.py | 514 +----------------- > pyanaconda/storage/storage_log.py | 4 > pyanaconda/tsort.py | 102 +++ > tests/Makefile.am | 4 > tests/storage_test/Makefile.am | 2 > tests/storage_test/action_test.py | 926 ++++++++++++++++++++++++++++++++++ > tests/storage_test/storagetestcase.py | 287 ++++++++++ > tests/tsort_test.py | 62 ++ The concept is sound, there's more test cases than actual code, there's less actual code afterwards, and the patches look okay from a quick run through. I say commit it and we'll deal with any little typos as they spring up later. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
