> @@ -533,6 +535,12 @@ void setStage2LocFromCmdline(char * arg, struct loaderData_s * ld) { > &(((struct nfsInstallData *)ld->stage2Data)->directory), > &(((struct nfsInstallData *)ld->stage2Data)->mountOpts)); > stripTrailingSlash(((struct nfsInstallData *)ld->stage2Data)->directory); > + > + logMessage(INFO, "method nfs - %s / %s / %s", > + (((struct nfsInstallData *)ld->stage2Data)->host), > + (((struct nfsInstallData *)ld->stage2Data)->directory), > + (((struct nfsInstallData *)ld->stage2Data)->mountOpts) > + ); > } else if (!strncmp(arg, "nfsiso:", 7)) { > ld->method = METHOD_NFS; > ld->stage2Data = calloc(sizeof(struct nfsInstallData), 1); Just nitpicking, but using slashes for the field separators is probably going to look confusing given that directory can contain slashes. Pipes or something else might be more legible. Aside from that, these both look fine. The second one in particular is a good find. - Chris _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list