Re: [PATCH master] Redirect uncpio errors to syslog (#618181)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/28/2010 08:51 AM, Chris Lumens wrote:
@@ -504,7 +505,7 @@ int myCpioInstallArchive(gzFile stream, struct cpioFileMapping * mappings,

      do {
  	if ((rc = getNextHeader(&fd,&ch, NULL))) {
-	    fprintf(stderr, _("error %d reading header: %s\n"), rc,
+	    logMessage( WARNING, _("error %d reading header: %s\n"), rc,
  		    myCpioStrerror(rc));
  	    return CPIOERR_BAD_HEADER;
  	}
@@ -755,7 +756,7 @@ int myCpioFilterArchive(gzFile inStream, gzFile outStream, char ** patterns) {

      do {
  	if ((rc = getNextHeader(&inFd,&ch,&pHeader))) {
-	    fprintf(stderr, _("error %d reading header: %s\n"), rc,
+	    logMessage( WARNING, _("error %d reading header: %s\n"), rc,
  		    myCpioStrerror(rc));
  	    return CPIOERR_BAD_HEADER;
  	}

We typically do not translate messages sent to the log files, since we
are the primary users of the logs and it's more confusing for us.

I just carried over what was already there (including ugly uses of tabs). Should I convert that back to a plain old string? And if so, myCpioStrerror() is also returning translations, should those be cleaned up as well?

--
Brian C. Lane <bcl@xxxxxxxxxx>
Red Hat / Port Orchard, WA

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux