-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/15/2010 02:31 AM, Steffen Maier wrote: > On 07/14/2010 07:02 PM, Brian C. Lane wrote: >> On 07/14/2010 07:36 AM, Martin Sivak wrote: >>> This gets rid of ugly checking for this in /proc/cmdline in loader and init checks if devel is actually a single word to avoid conflicts >>> --- >>> loader/init.c | 36 +++++++++++++++++++++++++++++++++--- >>> loader/loader.c | 28 +++++++++++++--------------- >>> 2 files changed, 46 insertions(+), 18 deletions(-) > >> I think you could simplify this by using strstr(develstart, " devel"), >> that would eliminate the need to strip spaces and do a strncmp on every >> word of the command line. >> >> devel is always going to have a space in front of it, so you only have >> to confirm that it is a single word. > > What if I put "devel" as first option into my boot options? > Technically true. But in every case I've seen the command line already has a number of things on it (initrd, stage2, etc.) and I'm too lazy to add options at the front of the line ;) - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBTD8/bxF+jBaO/jp/AQJPtwgAoqxgwK/jWiJu9OyHC3rN8+uIuETTJIEL 99FG32WvtXck3sssiaj7hkzbACL1z4BelDrOrMnidw7Vjv8WoFpwDQv0pO4zcent yuFBqLVtZp88tGRQe28WK0vlYAwz3++xSspIv5LTllle2F8qG04LUdos5B94307L XnCT+N9nojYx4fL1kmHj/d2yYRusitQ74j5wnXbB4uFTcTDGtl3/Kb8wCpbaAtoJ 3yCuxKK/YeDCmxyxrPYQWu1xWbKCrba0iLXaTZvVmAJFj5A5Xcqn2Ug0Jv4Lae5Z fTrH0uS3UerZQoZfpZkafZ4jAKIvH7iAJwruySw7AjyUvwH+D51I0A== =TWZ6 -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
