On 07/07/2010 12:56 PM, Ales Kozumplik wrote:
> On 07/07/2010 09:16 AM, Martin Sivak wrote:
>> + /* check for development mode early */
>> + if (g_file_get_contents("/proc/cmdline",&buf, NULL, NULL) == TRUE) {
>> + if (strstr(buf, "devel")) {
>> + isDevelMode = 1;
>> + }
>> + g_free(buf);
>> + }
> 2) this will break if another kernel argument or option containing
> 'devel' is used. like in "inexpertlydevelopedmode".
Good point. We already have such an issue with loglevel=:
https://bugzilla.redhat.com/show_bug.cgi?id=603136
Even though existing cmdline parsing in loader is somewhat fuzzy,
new options should probably try to avoid such ambiguities.
Steffen
Linux on System z Development
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
