Re: [PATCH 1/2] Add better debugging capabilities to loader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/07/2010 09:16 AM, Martin Sivak wrote:
- when development ('devel' argument) mode is requested, init enables
   core dumping and starts shell in the case of unexpected exit
---

Ack, with one nitpick about:

+    /* unless the user specifies that they want utf8 */
+    int fdn;
+    if ((fdn = open("/proc/cmdline", O_RDONLY, 0)) != -1) {
+        int len = read(fdn, buf, sizeof(buf) - 1);
+        close(fdn);
+        if (len>  0&&  strstr(buf, "devel")) {
+            printf("Enabling development mode - cores will be dumped\n");
+            isDevelMode = 1;
+        }
+    }

The command line parsing is also happening in your second patch and could be isolated into a function is isys somewhere?

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux