I also think this patch set is heading in a very good direction.
> @@ -872,6 +897,25 @@ int main(int argc, char **argv) {
> printf("-- received signal %d", WTERMSIG(waitStatus));
> }
> printf("\n");
> +
> + /* If debug mode was requested, spawn shell */
> + if(isDebugMode) {
> + pid_t shellpid;
> +
> + printf("Development mode requested spawning shell...\n");
> +
> + if ((shellpid = fork()) == 0) {
> + execl("/sbin/bash", "/sbin/bash", NULL);
> + }
> + else if (shellpid > 0) {
> + waitpid(shellpid, NULL, 0);
> + }
> + else {
> + perror("Execution of debug shell failed.");
> + }
> +
> + }
> +
> } else {
> shutdown_method = REBOOT;
> }
We start a shell on tty2 in various circumstances. I'd love it if we
got rid of all the circumstances and just always had init spawn a shell
on tty2.
I guess the advantage of your way is that we'll have it for serial
console installs, too. Still - I think we should get rid of any
conditions to starting the tty2 shell and just do it as early as
possible.
- Chris
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
