Hi,
I could postpone checking cmdline arguments, but then I would have to either delay initialization of signal handlers or initialize them and then deinitialize again. I'm not really sure what is cleaner.
--
Martin Sivák
msivak@xxxxxxxxxx
Red Hat Czech
Anaconda team / Brno, CZ
----- "Ales Kozumplik" <akozumpl@xxxxxxxxxx> wrote:
> On 06/30/2010 02:44 PM, Martin Sivak wrote:
> > - also make sure the terminal is in usable state when back in init
>
>
> This looks good, except:
> > + /* check for development mode early */
> > + int fdn;
> > + if ((fdn = open("/proc/cmdline", O_RDONLY, 0)) != -1) {
> > + int len = read(fdn, buf, sizeof(buf) - 1);
> > + close(fdn);
> > + if (len> 0&& strstr(buf, "devel")) {
> > + printf("Enabling development mode - cores will be
> dumped\n");
> > + isDevelMode = 1;
> > + }
> > + }
>
> this duplicates the command line processing in loader.c. I would
> prefer
> putting this into parseCmdLineFlags() and moving execution of that
> function to 'soon enough' place.
> Ales
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
