On 06/30/2010 01:26 PM, Martin Sivak wrote:
- when development ('devel' argument) mode is requested, init enables
core dumping and starts shell in the case of unexpected exit
---
loader/init.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++-----
loader/loader.c | 7 -------
2 files changed, 49 insertions(+), 12 deletions(-)
Hi,
I applaud to this initiative. No ack yet though:
This:
+ if (isDebugMode) {
+ /* if anaconda dies suddenly we are doomed, so at least make a coredump */
+ struct rlimit corelimit = { RLIM_INFINITY, RLIM_INFINITY};
+ int ret = setrlimit(RLIMIT_CORE,&corelimit);
+ if (ret) {
+ perror("setrlimit failed - no coredumps will be available");
Together with this:
- /* if anaconda dies suddenly we are doomed, so at least make a coredump */
- struct rlimit corelimit = { RLIM_INFINITY, RLIM_INFINITY};
- ret = setrlimit(RLIMIT_CORE,&corelimit);
- if (ret) {
- perror("setrlimit failed");
- }
-
Means core won't be dumped if the anaconda process is killed suddenly
for an obscure reason, which was exactly why I introduced this. In other
words: the next time we see strange irregular crashes we want to get the
core file straight away and not ask the QAs to try again with a special
cmdline parameter.
Also, since you are setting the core limit in init.c now, please also
test that sending ABRT to anaconda still results in the core dump.
Ales
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
