On 06/30/2010 12:13 PM, Hans de Goede wrote: > I just noticed the following in dasd.py: > > if status in ["unformatted"] and device not in exclusiveDisks: > > This seems wrong, as exclusiveDisks is not a list of disks to filter, > but the opposite it is a list of disks which we are allowed to touch, > so the proper test would be: > > if status in ["unformatted"] and (not exclusiveDisks or > device in exclusiveDisks): Cool, thanks, we missed that. If that's wrong it may cause potential data loss. > Note that this code likely currently still works properly as > DASD().startup() gets called > for the first time from the filter UI when building the disk list and at > this time > exclusiveDisks is empty. > > I do find this strange though, what is the use of having an > exclusiveDisks parameter to DASD().startup() to allow filtering out dasd's > from dasd formatting if we call DASD().startup() before the user has been > able to select which disks to filter out (and thus to populate > exclusiveDisks). Exactly, that seems very much related to what I was referring to in an earlier discussion I started and which was IMHO not finished: https://www.redhat.com/archives/anaconda-devel-list/2010-April/msg00236.html Steffen Linux on System z Development IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
