On Wed, 30 Jun 2010, Ales Kozumplik wrote:
On 06/29/2010 08:35 PM, Adam Jackson wrote:
Otherwise, we lose arbitrary amounts of X server state, since we're not
waiting for metacity before carrying on; and any driver bugs that cause
crashes on regeneration will cause graphical install to fail entirely.
This varies slightly from the usual policy of doing what the installed
system would do, but I'm willing to turn a blind eye. The more correct
fix would be waiting for one of the properties metacity creates to exist
on the root window. This is harder than you think.
Signed-off-by: Adam Jackson<ajax@xxxxxxxxxx>
Hi Ajax,
def doShutdownX11Actions():
global wm_pid
+ global xserver_pid
if wm_pid is not None:
try:
@@ -128,6 +130,13 @@ def doShutdownX11Actions():
except:
pass
+ if xserver_pid is not None:
+ try:
+ os.kill(xserver_pid, 15)
+ os.waitpid(xserver_pid, 0)
+ except:
+ pass
+
This is not your fault but the last time doShutdownX11Actions() was called
was in 2006 (a9240ccced95966c0739419b62bce0367f378e40). It should go. Is that
a problem that the X will be staying alive?
proc = subprocess.Popen(["Xorg", "-br", "-logfile",
"/tmp/X.log",
+ "-noreset"],
This looks reasonable, I'm just afraid to find out why it isn't so by
default.
Also--the patch needs to be submitted to master too.
I only applied it to rhel6-branch, fyi. The patch was not able to cleanly
apply and for master it was even more difficult. Would prefer an updated
patch for master.
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
