Re: [PATCH] Force the comps object to be reloaded after adding repos (#606765).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Lumens wrote:
This will make it so the repo metadata from any new or changed repos will be
merged in, therefore making groups selectable in the UI.  There are simply
too many places where a repo can be modified to conditionalize this so
hopefully it does not take too long.
---
 iw/task_gui.py |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Looks good to me.

Just a note - this code that does the same after repo is added/edited in UI
(using deprecated doGroupSetup which sets comps to None and reloads
group info immediately) could go away then, but this is probably not the right
time to do it.

diff --git a/iw/task_gui.py b/iw/task_gui.py
index 8f9b4c8..c3cc800 100644
--- a/iw/task_gui.py
+++ b/iw/task_gui.py
@@ -384,17 +384,6 @@ class RepoEditor:
log.warning("error removing cachedir for %s: %s" %(self.repo, e))
                    pass

-            if (newRepoObj.enablegroups or
-                (removeOld and self.repo.enablegroups)):
-                # update groups information
-                try:
-                    self.anaconda.backend.ayum.doGroupSetup()
-                except Exception as e:
- log.debug("unable to reset group information after UI repo edit: %s"
-                              % e)
-                else:
-                    log.info("group information reset after UI repo edit")
-
            self.repo = newRepoObj
            break

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux