-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/17/2010 04:23 AM, Ales Kozumplik wrote: > > What I am going to do before pushing is > 1) wait for comments and objections It looks good to me, with a couple of comments. Some of the module references are getting ridiculously long: pyanaconda.storage.fcoe.has_fcoe() should ideally be fcoe.has_fcoe(), or at most storage.fcoe.has_fcoe() (that's just one example). I see that we have some pre-existing dotted notation relative imports in the code: from ..errors import * It would make sense to me to clean these up to match importing from pyanaconda.whatever instead so that things are consistent. (and as an unrelated nit, I really dislike import *, it makes it really hard to trace something back to its source, but I don't see that changing anytime soon) > 2) try a scratch compose to see that everything still works > 3) fix the problem of updates.img having to include everything Is having it all really a big problem? It isn't that big, and it is alot less complication to just drop it all in instead of trying to mix with existing modules. So, in general I'd say ack * 11 - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Remember Lexington Green! iQEVAwUBTBqsIRF+jBaO/jp/AQLSrwf/UO4h8kWg0gxbX+ar13m4D4MQ1JDRul+U o6VLjigGTsAQVe7esocIxPY6+QcfUjyAZT/Xq7ElrYWJkNWqx+WLSuc21Ald572B zFR92jFKYtYLEmOaStef1WLYrkX+9ruL/1crq3HLRuD53O++icLBYAOQOsXOjRrK LoljNKYNtS9boUBEpXHGFm2352/OBDhNsjO3QG2yHEm6ebzq/9DBgdfjkuE5hRZb gikJLmDrwJe/DbWnQn/iPuJQpXMG1rRIP1g4EV5MNRlNsKUOmRMBGTO3sm+w5gdY pySRhAsaiwweLez1VnbwEDFveUYTo3zzhKao9LDwSJ2KDyGvoqtMBQ== =fLDx -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
