On Thu, 17 Jun 2010, Chris Lumens wrote:
I changed the loader/urls.c proxy regex to match the python one so that the
unit tests will apply to it as well.
I'm not terribly happy with having the regex for proxy defined in 3 places,
but I don't see any good alternatives.
If you find it offensive, you could always put the regex in a header in
isys and expose it to python via isys.py. That's differently gross,
though.
In the unit test I print all the proxy regex errors found before failing, I
think this is more useful than having it stop on the first failure.
Wonderful, seeing test cases for this kind of stuff is fantastic. Now
to remember to run the test cases regularly. I could add them to
checkbot, I guess.
I would to have a 'make test' or 'make check' target that we can run from
%check in the anaconda spec file. We would not be able to test everything
that way, but we could run through a lot of unit tests.
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
