This set of patches fixes and enhances the proxy regex, adds unit tests for them and fixes a problem with setting repo.proxy -- yum parses this when it it set, so it needs to be complete instead of built as you go. I changed the loader/urls.c proxy regex to match the python one so that the unit tests will apply to it as well. I'm not terribly happy with having the regex for proxy defined in 3 places, but I don't see any good alternatives. In the unit test I print all the proxy regex errors found before failing, I think this is more useful than having it stop on the first failure. Brian C. Lane (4): Replace POSIX regex classes with character ranges (#602712) Add test cases for proxy regex (#602712) Change proxy regex in loader to match python proxy regex (#602712) Set repo.proxy only after fully assembled (#602712) loader/urls.c | 2 +- tests/regex/Makefile.am | 22 +++++++++ tests/regex/proxy.py | 111 +++++++++++++++++++++++++++++++++++++++++++++++ yuminstall.py | 20 ++++++--- 4 files changed, 148 insertions(+), 7 deletions(-) create mode 100644 tests/regex/Makefile.am create mode 100644 tests/regex/__init__.py create mode 100644 tests/regex/proxy.py _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
