Hi,
Using addUdevDiskDevice will lead to no model argument being passed into the
DiskDevice constructor for regular disks, and will pass in a bus argument
which the old code does not do.
I'm not sure if either is a problem, though.
Regards,
Hans
On 06/07/2010 03:18 AM, Steffen Maier wrote:
Multipath members also need to be distinguished between the different
subclasses of DiskDevice for dracutSetupString to work.
addUdevDiskDevice already does this distinction for us and knows
iSCSI, FCoE, MD container, DASD, zFCP, or DiskDevice for everything else.
---
pyanaconda/storage/devicetree.py | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py
index 67c8f65..5d93336 100644
--- a/pyanaconda/storage/devicetree.py
+++ b/pyanaconda/storage/devicetree.py
@@ -1239,14 +1239,8 @@ class DeviceTree(object):
# The first step is to either look up or create the device
#
if udev_device_is_multipath_member(info):
- device = DiskDevice(name,
- major=udev_device_get_major(info),
- minor=udev_device_get_minor(info),
- sysfsPath=sysfs_path, exists=True,
- serial=udev_device_get_serial(info),
- vendor=udev_device_get_vendor(info),
- model=udev_device_get_model(info))
- self._addDevice(device)
+ if device is None:
+ device = self.addUdevDiskDevice(info)
elif udev_device_is_dm(info) and \
devicelibs.dm.dm_is_multipath(info):
log.debug("%s is a multipath device" % name)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
