Re: [master&rhel6-branch 2/3] Fix readNetInfo and writeEnabledNetInfo for s390 (#595388)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Before f17d989bc2cb50ffaedcf97a332095180511a272, writeEnabledNetInfo
> did not seem to be called on s390. Now that it is, it turned out that
> readNetInfo and writeEnabledNetInfo are not complete.
> 
> Loader does not need to handle or understand layer2 and portno so
> consolidate that into opaque options. This will prevent issues such as
> ef100b6baa5324fb5f5060b21f804bddc16ebead or
> 9caaca40bcaffb502dc58659e828f97d78a2d0f8
> and is also transparent to future extensions in linuxrc.
> 
> Really ignore parm/conf file options that are deprecated,
> otherwise fixed loader would leave them in the ifcfg file.
> 
> Tell which stacks to configure in /etc/sysconfig/network
> 
> GATEWAY in ifcfg is really IPv4 only.
> 
> Please fixed loader to parse DNS and write DNS1,DNS2,... itself (again).
> 
> Correctly parse OPTIONS whose value includes equal signs because
> the values are attribute value pairs. See also bug 597205 and
> 8549a36d4b22171992951a272b82f0aa14234dc4.
> 
> Do parse DOMAIN for DNS search suffixes which are very hand on s390
> where it's sometimes hard to write more than 80 chars for
> repo/stage2/updates etc. Also write out quoted since it is a whitespace
> separated list.
> 
> Don't write HWADDR on s390. See also 3411cda88be7ec7fe57ec5c9c73d15148354a414
> and 2c1aab43a1010ec0e113fa86e4daea9cd99de7f6 (bug 546005) or bug 591533.

Please fix one issue per commit.  Having giant catch-all commits like
this makes it more difficult to see what's going on in the history.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux