-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It appears that even though RB knows how to parse patches it doesn't know how to parse the commit message or subject line in the git *.patch files. This is annoying and adds a couple of redundant tasks in order to get it reviewed. ie. manually adding a summary via the web interface, and adding a description. These should be picked up from the patch. Ideally this would be as easy to use as 'git send-reviewboard *.patch' on the command line. I know there is an attempt at a command line tool, but when I tried it last time it wouldn't even recognize that there was an anaconda repo to add the review to. I would almost be more useful to add a bot to the mailing list that picks up patches and adds them to a temporary git repo so that the git web interface can be used on it to view the diff. Also, I'm not sure if review board really knew which branch to apply the patch to, or if it just uses master. I had to fill in the branch field manually, and that was after adding the patch. If it doesn't apply them to the correct branch that could make a mess of things in places where they diverge from master. - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBS+nSohF+jBaO/jp/AQJV0Af+MjaxdYIRIvfUyiD4uPRY6VXz2kGi2jiT NytDjaaXYYh+00LaGqoE8rDwlyWhIB9CVX6wsDuTwBGiYLRNu010OoFZyNtsmwex cOgQfvbKY+O3/92XypNIRN22r5RiQAwKweez247tpV/EIE17vPkkNuRGgtfnslDg 4kNYXXoMzFYNtTuRs2IpEQz42bUra0qPRS7K5rfMnm6U2cz7JackBDuQC8OWtXTE muC98L9vfUjgGXklxZOUD+S6G4+EkkU/2mmoF8YY1PUNoS9oOgPN9utdvYbfJu3p P4vhkeFzh2I29rZvSBFKCbOtPZ6lSz2EcFaRWJ35B3v6FyqJkqS8LQ== =b57E -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
