-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/05/2010 06:14 AM, Steffen Maier wrote: > On 05/05/2010 02:51 AM, David Cantrell wrote: >> On Wed, 5 May 2010, Steffen Maier wrote: >>> On 05/04/2010 11:40 PM, David Cantrell wrote: > >>>> --- >>>> utils/geninitrdsz.c | 51 >>>> +++++++++++++++++++++++++++++++++++---------------- >>>> 1 files changed, 35 insertions(+), 16 deletions(-) >>>> >>>> diff --git a/utils/geninitrdsz.c b/utils/geninitrdsz.c >>>> index 6dfd976..b8c824a 100644 >>>> --- a/utils/geninitrdsz.c >>>> +++ b/utils/geninitrdsz.c >>>> @@ -1,11 +1,12 @@ >>>> /* >>>> - * geninitrdsz.c >>>> - * Generate initrd.size file for zSeries platforms. >>>> + * gen-initrd-addr.c >>> >>> * gen-initrd-patch.c >>> >>>> + * Generate initrd.addr file for s390x platforms. >>> >>> * Generate initrd.patch file for s390x platforms. >> >> Does it really matter if it's called initrd.addr or initrd.patch? Or even >> initrd.size for that matter? I used initrd.addr thinking that it might >> be a >> good idea for people to not mistake this file for the output of diff(1). > > Agreed that a .patch suffix could be mixed up with textual diffs. > I don't like .addr (and .size neither). It is misleading because the > generated file does not just contain the load address but also the > initrd size, the latter of which we've always had and still need. Since > the generated file is actually a binary patch, how about > "initrd.binpatch" or "initrd.addrsize"? In the interest of injecting another opinion ;) I generally don't like . in file names, that should be reserved for file name types like .tar or .bz2 and the like. I think it should be something like initrd-blah and wouldn't complain about initrd-addr-patch or even initrd-patch - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBS+G5oxF+jBaO/jp/AQKHGwgAn0Jqq+/uIoJSrj2cL9LFfnkz5rpkykfT rNFH3ffmAMeJ0/1B6/0ZPjYgBLvETcYw7dx3bTS6MuObYnYNZuyGb52t/70nHfjy J2CsM4Loqrb98CxVGX6RDvKCgTvBm6iIK8p9yMmyjnBVk5lZ7B6g8uPSGD+QE+/3 WefYEgSL42Bkx4O8E+dp7yNwlrb4yQ8oox2UNY0LSkLXCT9Ehnl1UdEP9XBdERD+ OcfiQtqAbqAmKPQD2C+iwJCBM4jx/QDw+fDVIlozP45fuzfE3jALbxr3jALDj3zx xU313KH4fAPm+bP6fWV4VBOuMHz8Qbx9koUBVOGK8B+iFRJ2ioZbsw== =W4Fu -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
