-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/30/2010 03:56 PM, David Cantrell wrote: > On Fri, 30 Apr 2010, Brian C. Lane wrote: > >> On 04/30/2010 03:36 PM, Brian C. Lane wrote: >>> On 04/30/2010 01:27 PM, David Cantrell wrote: >>>> Yesterday I posted some patches for review on ReviewBoard. Since >>>> the email >>>> notices are not currently set up, I'm sending this out. >>> >>> I don't like not being able to view diffs and reviews at the same time. >>> > >> I guess I should add that I do like the colorized diff view. It would be >> more useful if you could see the other reviewer's comments. > >> How did you submit the diffs? Is the command line working now or did you >> have to use the web interface? > > I submitted the patches via the web interface. You should be able to see > other comments. The anaconda review group may not be set up correctly, > but I > think as long as you are in that group, you can see everything. > eg. I click on View Diff and get this page with the diff: https://fedorahosted.org/reviewboard/r/22/diff/#index_header but it doesn't show Chris' review. If I click on 'View Reviews' I get this: https://fedorahosted.org/reviewboard/r/22/ The reviews are shown, but no diffs. - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQEVAwUBS9tj7BF+jBaO/jp/AQL7pwf/chWV54kWYhsm2XGVerHpKDO06hSlv4KA HCmnGofXYorOa057lZIOfyV1QzlAFIBMJouLo6bgjN17whDfiSsPubSsw2bCfKtT 3fSwcL8RjfsEyKZciuproQDGV/vKz5yewKo0wIhsZ+z462YK3wuK3xGDCCyW2a4x JM5Af/zcYzrgjb5A3D1OkxWdmaR7YN5PeUL0MN9CQOBs0AYzFP+kO5A7PlaU4pbt MIv2E0Iyn7lqPs/PrckhFLw6IcFj+DA6AvoaXV6cEtvnXjbsl2T38dG6r0FkBbI7 pf5B2VzLXOqaO8ZiiO4QxUD99sz5y85vj8fYokwRmnKH/PEodJTaxQ== =nJCM -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
