Re: [PATCH rhel6-branch 2/3] Remove an unnecessary network test and bringup in doConfigSetup.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I don't understand why it is unnecessary. But removing seems right
> because in ks case we don't want UI interaction - we should probably
> check added repos in ks and try to bringUp network if needed
> (we do it only for method if we get network command in ks currently).

If you follow the code paths, you'll see there's no point to the check
in doConfigSetup there.  After doConfigSetup, we return to
AnacondaYum.setup.  After that's done, we return to
YumBackend.doBackendSetup.  Scroll down a couple lines and you'll see we
iterate over all enabled repos and bring up the network if needed.

Essentially, the one I'm removing is a duplicate check.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux