Re: [PATCH rhel6-branch 1/3] Add a method that fetches and returns the .treeinfo file.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Lumens wrote:

Looks good, just one thing...

---
 yuminstall.py |   25 +++++++++++++++++--------
 1 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/yuminstall.py b/yuminstall.py
index 858fe0a..05a3b69 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -589,6 +589,18 @@ class AnacondaYum(YumSorter):
return repo + def _getTreeinfo(self):
+        if os.access("%s/.treeinfo" % self.anaconda.methodstr, os.R_OK):
+            return "%s/.treeinfo" % self.anaconda.methodstr
+        else:
+            try:
+                ug = URLGrabber()
+                ug.urlgrab("%s/.treeinfo" % self.anaconda.methodstr,
+                           "/tmp/.treeinfo", copy_local=1)
+                return "/tmp/.treeinfo"
+            except:

I'd use except Exception, and log the exception.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux