Re: [master 2/2] nfs: off by one error leaves extra slash in a path.

David Cantrell <dcantrell@xxxxxxxxxx> · Thu, 22 Apr 2010 11:46:03 -1000 (HST)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ack.

On Thu, 22 Apr 2010, Ales Kozumplik wrote:

makes unpretty log messages.
---
loader/nfsinstall.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
index f24acec..b6c3c82 100644
--- a/loader/nfsinstall.c
+++ b/loader/nfsinstall.c
@@ -278,7 +278,7 @@ char * mountNfsImage(struct installMethod * method,

            if (!doPwMount(fullPath, "/mnt/stage2", "nfs", mountOpts, NULL)) {
                checked_asprintf(&buf, "/mnt/stage2/%s",
-                                 strrchr(directory, '/'));
+                                 strrchr(directory, '/') + 1);

                if (!access(buf, R_OK)) {
                    logMessage(INFO, "can access %s", buf);


- -- 
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvQw5sACgkQ5hsjjIy1VknuMACgnSGho2Hh9WyQ9NY7k2pLIpgq
dK4Anjx/uqFAAxtz7Q6dhwj5LDZZ5Ycn
=VIMr
-----END PGP SIGNATURE-----

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list




