Re: [PATCH 2/5] Let the user know if adding a zfcp drive fails (#582632)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ack, thanks.

On 04/16/2010 05:16 PM, Hans de Goede wrote:
> ---
>  textw/add_drive_text.py |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/textw/add_drive_text.py b/textw/add_drive_text.py
> index e690475..0fbd86c 100644
> --- a/textw/add_drive_text.py
> +++ b/textw/add_drive_text.py
> @@ -71,11 +71,10 @@ class addDriveDialog(object):
>          devnum = entries[0].strip()
>          wwpn = entries[1].strip()
>          fcplun = entries[2].strip()
> -        try:
> -            storage.zfcp.ZFCP().addFCP(devnum, wwpn, fcplun)
> -        except ValueError, e:
> -            log.warn(str(e)) # alternatively popup error dialog instead
> -                                        
> +
> +        # This may throw a value error, which gets handled by addDriveDialog()
> +        storage.zfcp.ZFCP().addFCP(devnum, wwpn, fcplun)
> +
>          return INSTALL_OK
> 
>      def addFcoeDriveDialog(self, screen):

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux