On Fri, 2010-04-16 at 13:58 +0200, Ales Kozumplik wrote:
> lv.format.currentSize remains on the original value all the time. This
> means that when the user resize the LV once, currentSize stays the same
> and the test for change in lvm_dialog_gui.py always succeeds every time
> the user reopens the LV edit dialog. This causes a traceback just below,
> in ActionResizeFormat.
Since you'll now be relying on targetSize to match currentSize when no
resize has been requested, you probably need to change
storage.formats.FS._setTargetSize so that a new value of None sets
self._targetSize to self.currentSize instead of None.
Otherwise, ack.
Dave
> ---
> iw/lvm_dialog_gui.py | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
> index b45c263..c06855b 100644
> --- a/iw/lvm_dialog_gui.py
> +++ b/iw/lvm_dialog_gui.py
> @@ -1152,10 +1152,10 @@ class VolumeGroupEditor:
> # check the lv's format also, explicitly, in case it is
> # encrypted. in this case we must check them both.
> if format.resizable and lv.format.resizable and \
> - lv.targetSize != format.currentSize and \
> - usedev.format.exists:
> - new_size = lv.targetSize
> - actions.append(ActionResizeFormat(usedev, new_size))
> + lv.targetSize != format.targetSize and \
> + usedev.format.exists:
> + log.debug("resizing format on %s to %d" % (usedev.lvname, lv.targetSize))
> + actions.append(ActionResizeFormat(usedev, lv.targetSize))
> elif lv.format.type:
> log.debug("new format: %s" % lv.format.type)
> # destroy old format and any associated luks devices
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
