Nack. https://bugzilla.redhat.com/show_bug.cgi?id=526364#c13 suggested this fix: # Only add "rhgb quiet" on non-s390, non-serial installs if iutil.isConsoleOnVirtualTerminal() and \ ( ts.dbMatch('provides', 'rhgb').count() or \ ts.dbMatch('provides', 'plymouth').count() ): anaconda.bootloader.args.append("rhgb quiet") You agreed in https://bugzilla.redhat.com/show_bug.cgi?id=526364#c14 that we have to use parenthesis to fix this. Hans, confirmed in https://bugzilla.redhat.com/show_bug.cgi?id=570743#c1 that the old code was not doing what it is supposed to be. Besides, iutil.isConsoleOnVirtualTerminal() already contains a check for iutil.isS390() since 047bc24212bd68942303242b864459bfc46be5d0 and we reuse this fact also in 516c91aecc21278f22565d55cb43feae2dd404cd which was also about "rhgb quiet" but broke the original fix of c1692ab69c9f280cf69cc1275f7416b32799cc89 unfortunately. Hence your patch only fixes s390 by means of boolean shortcut evaluation but not non-virtual terminal consoles such as serial lines in general. On 04/14/2010 07:02 PM, David Cantrell wrote: > --- > packages.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/packages.py b/packages.py > index 3d30635..754b5c4 100644 > --- a/packages.py > +++ b/packages.py > @@ -305,7 +305,7 @@ def rpmSetupGraphicalSystem(anaconda): > ts = rpm.TransactionSet(anaconda.rootPath) > > # Only add "rhgb quiet" on non-s390, non-serial installs > - if iutil.isConsoleOnVirtualTerminal() and \ > + if not iutil.isS390() and iutil.isConsoleOnVirtualTerminal() and \ > ts.dbMatch('provides', 'rhgb').count() or \ > ts.dbMatch('provides', 'plymouth').count(): > anaconda.id.bootloader.args.append("rhgb quiet") Steffen Linux on System z Development IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
