On 04/14/2010 10:03 PM, David Cantrell wrote: > On Wed, 14 Apr 2010, Hans de Goede wrote: >> Ack. >> >> Why not 0 though ? > > Because for autopart, we still want to enforce _some_ swap. It can be any > size though. I don't understand how autopart will now behave with minswap=1. I mean, the problem was that the ratio between suggested swap and remaining root-fs size was just very unbalanced. What will the balance be with minswap=1? Will we always get the smallest possible swap of 1M, now? >> On 04/14/2010 07:02 PM, David Cantrell wrote: >>> On s390x, set the minswap suggestion to 1 rather than 256, 1024, or the >>> amount of memory in the system. On s390x, it's common for users to run >>> with swap volumes smaller than the installed memory size, so align the >>> anaconda recommendations with that. >>> --- >>> iutil.py | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> diff --git a/iutil.py b/iutil.py >>> index a568ff7..d6e6e2f 100644 >>> --- a/iutil.py >>> +++ b/iutil.py >>> @@ -454,6 +454,9 @@ def swapSuggestion(quiet=0): >>> minswap = mem >>> maxswap = 2*mem >>> >>> + if isS390(): >>> + minswap = 1 >>> + >>> if not quiet: >>> log.info("Swap attempt of %sM to %sM", minswap, maxswap) >>> Steffen Linux on System z Development IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list